feat(weekly-stats): add load to weekly stats widget#1866
feat(weekly-stats): add load to weekly stats widget#1866hutchinsp01 wants to merge 2 commits intorobiningelbrecht:masterfrom
Conversation
|
@hutchinsp01 thanks for your PR. I noticed that there is a breaking change. Breaking changes imply that we need to release a new major version. |
|
In terms of stats, does it make sense to have this training load per week number? |
|
Hey, yep I'll make it backwards compatible. I assume it's okay to just add a fallback if only 3 values are provided to the config. In terms of if this is needed for stats, it's quite useful to compare week to week your training load for seeing whether or not you are over-training. I used to use the Strava premium load chart, but have since stopped paying for it and is something I used frequently. It is very similar to the Training Load Analysis, so maybe it makes more sense showing it there? But currently there is no where I can see the weekly TRIMP historically to compare. And this seemed like the most reasonable place to show it |
|
@hutchinsp01 we only keep track of the training load for YTD. This means that the weekly stats chart will stop showing "load" data once you go back more than 1 year. That's not ideal. |
|
Closing for now, will rethink how to integrate into Training Load analysis |
|
What about an extra tab here? 
|
2 participants
What type of PR is this? (check all applicable)
Description
Add's LOAD to the Weekly stats widget, useful for comparing week to week training.
Note
I had a look for tests for the weekly stats widget, but could only find the ones I've updated.
lmk if you want tests for the metrics individually
BREAKING CHANGES
'metricsDisplayOrder': ['distance', 'movingTime', 'elevation', 'load'] } }Fixes ISSUE_NUMBER